[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1255324708 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -409,6 +411,43 @@ private String getBrokerSideConfigValue(final

[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1255322606 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java: ## @@ -279,6 +279,28 @@ public CreateTopicsResult

[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1255320753 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -0,0 +1,264 @@ +package

[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1255321572 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -0,0 +1,264 @@ +package

[GitHub] [kafka] lihaosky commented on a diff in pull request #13851: KAFKA-15022: [1/N] initial implementation of rack aware assignor

lihaosky commented on code in PR #13851: URL: https://github.com/apache/kafka/pull/13851#discussion_r1244450143 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -409,6 +411,43 @@ private String getBrokerSideConfigValue(final