[GitHub] [kafka] lucasbru commented on a diff in pull request #13829: KAFKA-10199: Re-add revived tasks to the state updater after handling

2023-06-08 Thread via GitHub
lucasbru commented on code in PR #13829: URL: https://github.com/apache/kafka/pull/13829#discussion_r1222994406 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -294,7 +297,13 @@ private void closeDirtyAndRevive(final Collection

[GitHub] [kafka] lucasbru commented on a diff in pull request #13829: KAFKA-10199: Re-add revived tasks to the state updater after handling

2023-06-08 Thread via GitHub
lucasbru commented on code in PR #13829: URL: https://github.com/apache/kafka/pull/13829#discussion_r1222992405 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1970,6 +1970,29 @@ public void

[GitHub] [kafka] lucasbru commented on a diff in pull request #13829: KAFKA-10199: Re-add revived tasks to the state updater after handling

2023-06-08 Thread via GitHub
lucasbru commented on code in PR #13829: URL: https://github.com/apache/kafka/pull/13829#discussion_r1222946279 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -294,7 +297,13 @@ private void closeDirtyAndRevive(final Collection