[GitHub] [kafka] mumrah commented on a diff in pull request #13802: MINOR: Improve KRaftMigrationZkWriter test coverage

2023-06-13 Thread via GitHub
mumrah commented on code in PR #13802: URL: https://github.com/apache/kafka/pull/13802#discussion_r1228123874 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriterTest.java: ## @@ -195,9 +235,658 @@ public void iterateTopics(EnumSet interests,

[GitHub] [kafka] mumrah commented on a diff in pull request #13802: MINOR: Improve KRaftMigrationZkWriter test coverage

2023-06-08 Thread via GitHub
mumrah commented on code in PR #13802: URL: https://github.com/apache/kafka/pull/13802#discussion_r1223265946 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriterTest.java: ## @@ -195,9 +235,658 @@ public void iterateTopics(EnumSet interests,

[GitHub] [kafka] mumrah commented on a diff in pull request #13802: MINOR: Improve KRaftMigrationZkWriter test coverage

2023-06-06 Thread via GitHub
mumrah commented on code in PR #13802: URL: https://github.com/apache/kafka/pull/13802#discussion_r1219834583 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -223,16 +223,16 @@ public void visitPartition(TopicIdPartition

[GitHub] [kafka] mumrah commented on a diff in pull request #13802: MINOR: Improve KRaftMigrationZkWriter test coverage

2023-06-06 Thread via GitHub
mumrah commented on code in PR #13802: URL: https://github.com/apache/kafka/pull/13802#discussion_r1219833727 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -267,6 +267,9 @@ void handleTopicsDelta( ) {

[GitHub] [kafka] mumrah commented on a diff in pull request #13802: MINOR: Improve KRaftMigrationZkWriter test coverage

2023-06-06 Thread via GitHub
mumrah commented on code in PR #13802: URL: https://github.com/apache/kafka/pull/13802#discussion_r1219791584 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -475,12 +478,13 @@ void handleProducerIdSnapshot(ProducerIdsImage