[GitHub] [kafka] novosibman commented on a diff in pull request #13782: Suggest for performance fix: KAFKA-9693 Kafka latency spikes caused by log segment flush on roll - trunk version

2023-06-14 Thread via GitHub
novosibman commented on code in PR #13782: URL: https://github.com/apache/kafka/pull/13782#discussion_r1230002264 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -976,6 +976,30 @@ public static void flushDir(Path path) throws IOException { }

[GitHub] [kafka] novosibman commented on a diff in pull request #13782: Suggest for performance fix: KAFKA-9693 Kafka latency spikes caused by log segment flush on roll - trunk version

2023-06-08 Thread via GitHub
novosibman commented on code in PR #13782: URL: https://github.com/apache/kafka/pull/13782#discussion_r1223374923 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -681,7 +687,12 @@ private static void writeSnapshot(File file, Map

[GitHub] [kafka] novosibman commented on a diff in pull request #13782: Suggest for performance fix: KAFKA-9693 Kafka latency spikes caused by log segment flush on roll - trunk version

2023-06-08 Thread via GitHub
novosibman commented on code in PR #13782: URL: https://github.com/apache/kafka/pull/13782#discussion_r1223373702 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -430,11 +428,19 @@ public Optional lastEntry(long producerId) {