[GitHub] [kafka] showuon commented on a diff in pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

2023-06-22 Thread via GitHub
showuon commented on code in PR #13760: URL: https://github.com/apache/kafka/pull/13760#discussion_r1238266317 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] showuon commented on a diff in pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

2023-06-22 Thread via GitHub
showuon commented on code in PR #13760: URL: https://github.com/apache/kafka/pull/13760#discussion_r1238257723 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2359,31 +2334,22 @@ public void testDeleteRecords() throws Exception {

[GitHub] [kafka] showuon commented on a diff in pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

2023-06-14 Thread via GitHub
showuon commented on code in PR #13760: URL: https://github.com/apache/kafka/pull/13760#discussion_r1229107591 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2359,31 +2334,22 @@ public void testDeleteRecords() throws Exception {

[GitHub] [kafka] showuon commented on a diff in pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

2023-06-13 Thread via GitHub
showuon commented on code in PR #13760: URL: https://github.com/apache/kafka/pull/13760#discussion_r1228079251 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2925,123 +2919,11 @@ void handleFailure(Throwable throwable) { @Override

[GitHub] [kafka] showuon commented on a diff in pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

2023-06-08 Thread via GitHub
showuon commented on code in PR #13760: URL: https://github.com/apache/kafka/pull/13760#discussion_r1222617381 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2291,6 +2289,8 @@ public void testDeleteRecords() throws Exception {

[GitHub] [kafka] showuon commented on a diff in pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

2023-06-08 Thread via GitHub
showuon commented on code in PR #13760: URL: https://github.com/apache/kafka/pull/13760#discussion_r1222617381 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2291,6 +2289,8 @@ public void testDeleteRecords() throws Exception {