[GitHub] [kafka] urbandan commented on pull request #13796: KAFKA-14034 Idempotent producer should wait for preceding in-flight b…

2023-06-14 Thread via GitHub
urbandan commented on PR #13796: URL: https://github.com/apache/kafka/pull/13796#issuecomment-1590766255 Thank you for the info. I'd say that in isolation, this specific issue (KAFKA-14034) should be resolved by retrying the in-flight batches. Are you suggesting that until KAFKA-14359 is

[GitHub] [kafka] urbandan commented on pull request #13796: KAFKA-14034 Idempotent producer should wait for preceding in-flight b…

2023-06-08 Thread via GitHub
urbandan commented on PR #13796: URL: https://github.com/apache/kafka/pull/13796#issuecomment-1582188829 > I guess I just need to clarify what retried batches are here -- is the idea that we wait for inflight batches to return a response or time out? What if the response triggers another

[GitHub] [kafka] urbandan commented on pull request #13796: KAFKA-14034 Idempotent producer should wait for preceding in-flight b…

2023-06-07 Thread via GitHub
urbandan commented on PR #13796: URL: https://github.com/apache/kafka/pull/13796#issuecomment-1580030486 @viktorsomogyi Since this part of the code is quite tricky, I would try to address the different issues in different PRs. I believe that the fix I'm proposing will solve the issue

[GitHub] [kafka] urbandan commented on pull request #13796: KAFKA-14034 Idempotent producer should wait for preceding in-flight b…

2023-06-05 Thread via GitHub
urbandan commented on PR #13796: URL: https://github.com/apache/kafka/pull/13796#issuecomment-1576211511 > > Instead, the producer should wait for the preceding, retried batches to complete before resetting the sequence number. This ensures that the sequence numbers can only get reset

[GitHub] [kafka] urbandan commented on pull request #13796: KAFKA-14034 Idempotent producer should wait for preceding in-flight b…

2023-06-02 Thread via GitHub
urbandan commented on PR #13796: URL: https://github.com/apache/kafka/pull/13796#issuecomment-1573381258 @philipnee @ijuma @hachikuji @jolshan Could you please review this fix? Based on the git history, you made changes lately in the related code. -- This is an automated message from the

[GitHub] [kafka] urbandan commented on pull request #13796: KAFKA-14034 Idempotent producer should wait for preceding in-flight b…

2023-06-01 Thread via GitHub
urbandan commented on PR #13796: URL: https://github.com/apache/kafka/pull/13796#issuecomment-1572188562 @viktorsomogyi Could you please review this fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above