vcrfxia commented on code in PR #13830:
URL: https://github.com/apache/kafka/pull/13830#discussion_r1223656443
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeyValueBuffer.java:
##########
@@ -27,14 +26,14 @@
import java.util.function.Consumer;
import java.util.function.Supplier;
-public interface TimeOrderedKeyValueBuffer<K, V> extends StateStore {
+public interface TimeOrderedKeyValueBuffer<K, V, T> extends StateStore {
Review Comment:
Can we add a quick javadoc to clarify that `T` here is the buffer type?
Should already be clear to anyone who reads the code, but a javadoc will help
make it so readers won't need to read the code if all they want to know is what
the type is.
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java:
##########
@@ -65,7 +65,7 @@
import static
org.apache.kafka.streams.state.internals.TimeOrderedKeyValueBufferChangelogDeserializationHelper.deserializeV3;
import static
org.apache.kafka.streams.state.internals.TimeOrderedKeyValueBufferChangelogDeserializationHelper.duckTypeV2;
-public final class InMemoryTimeOrderedKeyValueBuffer<K, V> implements
TimeOrderedKeyValueBuffer<K, V> {
+public final class InMemoryTimeOrderedKeyValueBuffer<K, V, T> implements
TimeOrderedKeyValueBuffer<K, V, Change<V>> {
Review Comment:
Could be good to rename this to `InMemoryTimeOrderedKeyValueChangeBuffer` to
contrast with `RocksDBTimeOrderedKeyValueBuffer` (not a change buffer) in your
next PR, but I don't feel too strongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
