[GitHub] [kafka] vcrfxia commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

vcrfxia commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1239143225 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinTest.java: ## @@ -112,6 +125,74 @@ private void pushNullValueToTable() {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

vcrfxia commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1239142854 ## streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java: ## @@ -189,7 +221,22 @@ public Joined withOtherValueSerde(final Serde otherValueSerde) {