[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1244739834 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -56,10 +77,59 @@ public void init(final ProcessorContext

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1244730962 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -56,10 +77,59 @@ public void init(final ProcessorContext

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1244729657 ## streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java: ## @@ -189,7 +221,22 @@ public Joined withOtherValueSerde(final Serde otherValueSerde) {

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1238801056 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -56,10 +77,60 @@ public void init(final ProcessorContext

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1234687152 ## streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinWithGraceIntegrationTest.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1232839068 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinWithGraceTest.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1232831833 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -56,10 +75,63 @@ public void init(final ProcessorContext