[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-22 Thread via GitHub
yashmayya commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1238244318 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1317,192 @@ void alterSinkConnectorOffsets(String connName, Connector

[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-10 Thread via GitHub
yashmayya commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1224138055 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1338,188 @@ void alterSinkConnectorOffsets(String connName, Connector

[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-09 Thread via GitHub
yashmayya commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1224138055 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1338,188 @@ void alterSinkConnectorOffsets(String connName, Connector

[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-08 Thread via GitHub
yashmayya commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1222869378 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1268,39 +1270,55 @@ public void alterConnectorOffsets(String connName, Map

[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-07 Thread via GitHub
yashmayya commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1221937078 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1587,10 +1595,11 @@ private boolean

[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-06 Thread via GitHub
yashmayya commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1219524567 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1338,188 @@ void alterSinkConnectorOffsets(String connName, Connector