Re: [PR] [Draft] Add type check to classic group timeout operations [kafka]

2024-04-04 Thread via GitHub
dongnuo123 commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1552050811 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2451,6 +2451,8 @@ private CoordinatorResult

Re: [PR] [Draft] Add type check to classic group timeout operations [kafka]

2024-04-04 Thread via GitHub
dajac commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1551577818 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2814,7 +2820,9 @@ private CoordinatorResult

[PR] [Draft] Add type check to classic group timeout operations [kafka]

2024-03-23 Thread via GitHub
dongnuo123 opened a new pull request, #15587: URL: https://github.com/apache/kafka/pull/15587 When implementing the group type conversion from a classic group to a consumer group, if the replay of conversion records fails, the group should be reverted back including its timeouts. A