Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1578348187 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -40,6 +40,7 @@ import static

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1578346148 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -979,6 +1013,13 @@ void handleCoordinatorReady() {

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on PR #15657: URL: https://github.com/apache/kafka/pull/15657#issuecomment-2075537428 Thanks @CalvinConfluent I will try to take a look sometime today  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [No Review] Kafka-14563 [kafka]

CalvinConfluent commented on PR #15657: URL: https://github.com/apache/kafka/pull/15657#issuecomment-2075521654 @jolshan Updated the PR 1. Reverted the KafkaApi changes. Now if the produce request with the TransactionV2 supported version, the server will process it no matter what

Re: [PR] [No Review] Kafka-14563 [kafka]

CalvinConfluent commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1578298683 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -109,7 +109,7 @@ class AddPartitionsToTxnManager(

Re: [PR] [No Review] Kafka-14563 [kafka]

CalvinConfluent commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1578296803 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -402,6 +412,30 @@ public synchronized void

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1558104084 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel, } else if

Re: [PR] [No Review] Kafka-14563 [kafka]

CalvinConfluent commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1558097863 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel, } else if

Re: [PR] [No Review] Kafka-14563 [kafka]

CalvinConfluent commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1557881030 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -979,6 +1013,13 @@ void handleCoordinatorReady() {

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1556614475 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -109,7 +109,7 @@ class AddPartitionsToTxnManager(

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1556609642 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -979,6 +1013,13 @@ void handleCoordinatorReady() {

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1556603619 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel, } else if

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1556603619 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel, } else if

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1556603619 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel, } else if

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1556584820 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -979,6 +1013,13 @@ void handleCoordinatorReady() {

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1556576980 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -402,6 +412,30 @@ public synchronized void

Re: [PR] [No Review] Kafka-14563 [kafka]

jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1556556192 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -202,7 +202,9 @@ public enum MetadataVersion { IBP_3_7_IV4(19, "3.7",