Re: [PR] [WIP] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-21 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1573635829 ## core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala: ## @@ -17,48 +17,78 @@ package kafka.server -import kafka.test.{ClusterConfig,

Re: [PR] [WIP] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-20 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1573570386 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -139,28 +159,46 @@ public Map nameTags() { return tags; } -public ClusterConfig

Re: [PR] [WIP] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-20 Thread via GitHub
chia7712 commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1573452044 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -139,28 +159,46 @@ public Map nameTags() { return tags; } -public ClusterConfig

[PR] [WIP] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-20 Thread via GitHub
brandboat opened a new pull request, #15761: URL: https://github.com/apache/kafka/pull/15761 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including