Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-03-09 Thread via GitHub
kamalcph commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1986805186 > Yeah, totally; I think the important thing is correcting the documentation, as people may be confused while reading it. Still, I don't know where the documentation is. Is it a

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-03-07 Thread via GitHub
federico-weisse-sportsbet commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1984501431 Yeah, totally; I think the important thing is correcting the documentation, as people may be confused while reading it. Still, I don't know where the documentation is.

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-03-07 Thread via GitHub
jolshan commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1984323889 @federico-weisse-sportsbet I see. We can update this branches but they may not be released again. If this is a concern for the website to have correct documentation it might be worth

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-28 Thread via GitHub
federico-weisse-sportsbet commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1970006347 Has been corrected for new versions on this [PR](https://github.com/apache/kafka/pull/13115). However, from version 3.1 to 3.4, the documentation must still be

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-28 Thread via GitHub
jolshan commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1969983039 @federico-weisse-sportsbet Is there a reason we targeted 3.2? Is this not a problem in future releases? We don't usually change aspects this far back since we likely won't release

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-23 Thread via GitHub
jolshan commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500883045 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-22 Thread via GitHub
federico-weisse-sportsbet commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500201095 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-22 Thread via GitHub
federico-weisse-sportsbet commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500201095 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-22 Thread via GitHub
federico-weisse-sportsbet commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500197041 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-22 Thread via GitHub
jolshan commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500128231 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-22 Thread via GitHub
federico-weisse-sportsbet commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500118164 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-22 Thread via GitHub
jolshan commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500063914 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-22 Thread via GitHub
federico-weisse-sportsbet commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500038952 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-22 Thread via GitHub
jolshan commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r155366 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {

[PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-21 Thread via GitHub
federico-weisse-sportsbet opened a new pull request, #15413: URL: https://github.com/apache/kafka/pull/15413 This should be greater than 1 to be consistent with behavior described in max.in.flight.requests.per.connection property. More detailed description of your change, if