Re: [PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

2024-04-25 Thread via GitHub
showuon merged PR #15801: URL: https://github.com/apache/kafka/pull/15801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

2024-04-25 Thread via GitHub
showuon commented on PR #15801: URL: https://github.com/apache/kafka/pull/15801#issuecomment-2076455539 The thread leaking failed tests disappeared now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

2024-04-24 Thread via GitHub
showuon commented on code in PR #15801: URL: https://github.com/apache/kafka/pull/15801#discussion_r1578771823 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -171,8 +162,8 @@ private String[]

Re: [PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

2024-04-24 Thread via GitHub
FrankYang0529 commented on PR #15801: URL: https://github.com/apache/kafka/pull/15801#issuecomment-2076141433 @chia7712, thanks for the hotfix. I'm very sorry for the inconvenient. The fix LGTM. It's better to use try-with-resource to close resource. Thanks. -- This is an automated

[PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

2024-04-24 Thread via GitHub
chia7712 opened a new pull request, #15801: URL: https://github.com/apache/kafka/pull/15801 Some services are not closed, so our CI print following error. ``` org.opentest4j.AssertionFailedError: Found 16 unexpected threads during @BeforeAll: `kafka-admin-client-thread |