calmera commented on PR #12742:
URL: https://github.com/apache/kafka/pull/12742#issuecomment-1987893614
Nice job @mjsax @wcarlson5! Sorry I couldn't spend more time on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mjsax commented on PR #12742:
URL: https://github.com/apache/kafka/pull/12742#issuecomment-1986241410
Merged to `trunk`. Thanks for the KIP and PR @calmera!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mjsax merged PR #12742:
URL: https://github.com/apache/kafka/pull/12742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wcarlson5 commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1516823620
##
streams/src/test/java/org/apache/kafka/streams/processor/ReadOnlyStoreTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mjsax commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1516564608
##
streams/src/test/java/org/apache/kafka/streams/processor/ReadOnlyStoreTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
wcarlson5 commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1515301279
##
streams/src/test/java/org/apache/kafka/streams/processor/ReadOnlyStoreTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mjsax commented on PR #12742:
URL: https://github.com/apache/kafka/pull/12742#issuecomment-1981929378
@calmera -- As discussed in person (a long time back...) I took the liberty
to update this PR. Hope we can get this merged soon.
--
This is an automated message from the Apache Git
mjsax commented on PR #12742:
URL: https://github.com/apache/kafka/pull/12742#issuecomment-1760672364
@calmera -- sorry to dropping the ball on this one -- can we resurrect it?
-- First step would be rebase to resolve the conflict.
--
This is an automated message from the Apache Git
