chia7712 merged PR #15512:
URL: https://github.com/apache/kafka/pull/15512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15512:
URL: https://github.com/apache/kafka/pull/15512#issuecomment-2008579703
the failed tests pass on my local:
```sh
./gradlew cleanTest :streams:test --tests
HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores
brandboat commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1530599572
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java:
##
@@ -1037,7 +1038,7 @@ public void
chia7712 commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1530236303
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/WakeupTriggerTest.java:
##
@@ -177,7 +177,7 @@ private void assertWakeupExceptionIsThrown(final
chia7712 commented on PR #15512:
URL: https://github.com/apache/kafka/pull/15512#issuecomment-2006002354
I have pushed a commit to rebase code and fix conflict. will merge it if
there is no connected failure.
--
This is an automated message from the Apache Git Service.
To respond to the
chia7712 commented on PR #15512:
URL: https://github.com/apache/kafka/pull/15512#issuecomment-2002292346
> should we include this one too ?
yep, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1527404009
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -850,7 +851,7 @@ public void testMetadataTimeoutWithMissingTopic(boolean
brandboat commented on PR #15512:
URL: https://github.com/apache/kafka/pull/15512#issuecomment-2002043253
gentle ping @chia7712, there is another case that could be replaced with
assertIsntanceOf
(in IntelliJ Find in files with regex `assertTrue\(\n?.*isInstance`)
brandboat commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1527189077
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -850,7 +851,7 @@ public void testMetadataTimeoutWithMissingTopic(boolean
chia7712 commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1527016313
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2718,7 +2719,7 @@ public void testDropCommitOnBatchExpiry()
brandboat opened a new pull request, #15512:
URL: https://github.com/apache/kafka/pull/15512
as title, replace
- `assertTrue(obj instanceof X)` with `assertInstanceOf(X.class, obj)`
- `assertTrue(obj instanceof X, errormessge)` with
`assertInstanceOf(X.class, obj, errormessage)`
11 matches
Mail list logo
