Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2024-05-01 Thread via GitHub
mjsax commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-2089475025 Very happy to see some activity on this PR. The release plan is in the wiki: https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.8.0 Feature freeze is May/29, so there

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2024-04-22 Thread via GitHub
vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-2071431998 No worries and thanks for the proposed help! There are some things which I need to close out but I do hope to close it out. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2024-04-17 Thread via GitHub
ableegoldman commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-2061827689 No pressure! Just wanted to make sure you weren't still waiting on me for this. Or rather, just wanted to say, if you do want to try and get this in to 3.8 I will make sure to help

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2024-04-17 Thread via GitHub
vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-2060631731 hey @ableegoldman .. i am interested in wrapping this up but i haven't looked at the streams codebase for some time and things seemed to have changed a bit. I am not aware of the

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2024-04-16 Thread via GitHub
ableegoldman commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-2059442356 Hey @vamossagar12 sorry the second half of this KIP has dragged on for so long. Are you still interested in getting this done? I think we can target it for 3.8 if you have time on

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-12-01 Thread via GitHub
vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1837036580 @ableegoldman , just checking if you got a chance to look at my comment above? Don't mean to be pushy on this but since 3.7 release is approaching, I thought I would want to have

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-11-23 Thread via GitHub
vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1824302840 Thanks @ableegoldman , that makes sense. Well I have another question again due to me not being upto date with the latest developments in streams. I have this test in

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-11-16 Thread via GitHub
ableegoldman commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1815619664 > do we need this pausing semantics for ReadOnlyTask as well? Alright so I'm not super familiar with this new code which seems to be related to the state updater, but IIUC the

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-11-16 Thread via GitHub
sean-rossignol commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1814804253 > Hey @sean-rossignol , thanks for explaining your use case and how this can be useful for you! I hope to push it in the upcoming 3.7 release. I haven't gotten the chance to

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-11-15 Thread via GitHub
vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1813728802 hey @ableegoldman , quick question. I am noticing that tests like `shouldRecoverFromInvalidOffsetExceptionOnRestoreAndFinishRestore` are failing with an error like ```

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-11-14 Thread via GitHub
vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1811121235 Hey @sean-rossignol , thanks for explaining your use case and how this can be useful for you! I hope to push it in the upcoming 3.7 release. I haven't gotten the chance to resolve

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-11-13 Thread via GitHub
sean-rossignol commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1809404175 Hey, anyway I could help unblock this pr @vamossagar12 ? We have an internal kstreams app with a wildcard consumer and one bottleneck we're hitting is as the number of

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1765609193 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has