chia7712 merged PR #12174:
URL: https://github.com/apache/kafka/pull/12174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #12174:
URL: https://github.com/apache/kafka/pull/12174#issuecomment-2044780100
@soarez I believe those failed tests are unrelated, but could you rebase
code to trigger QA again due to incompletion of `JDK 17 and Scala 2.13`?
--
This is an automated message from
soarez commented on PR #12174:
URL: https://github.com/apache/kafka/pull/12174#issuecomment-2044731959
@chia7712 done. It seems to me that the current test failures are unrelated.
Could you confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on PR #12174:
URL: https://github.com/apache/kafka/pull/12174#issuecomment-2041478299
@soarez Could you please fix the conflicts? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1554541084
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -260,9 +274,12 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
chia7712 commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1551687551
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -260,9 +274,12 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
chia7712 commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1551371510
##
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala:
##
@@ -197,12 +198,11 @@ class ServerShutdownTest extends KafkaServerTestHarness {
soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1551132979
##
core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java:
##
@@ -323,7 +324,7 @@ public void rollingBrokerRestart() {
throw new
soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1551132385
##
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala:
##
@@ -197,12 +198,11 @@ class ServerShutdownTest extends KafkaServerTestHarness {
soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1551129021
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -260,9 +274,12 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
chia7712 commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1549916567
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -260,9 +274,12 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1549909706
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -623,9 +623,12 @@ class BrokerServer(
}
}
- override def shutdown(): Unit = {
+ override def
soarez commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1549909351
##
core/src/main/scala/kafka/server/KafkaBroker.scala:
##
@@ -93,6 +93,7 @@ trait KafkaBroker extends Logging {
def startup(): Unit
def awaitShutdown(): Unit
chia7712 commented on code in PR #12174:
URL: https://github.com/apache/kafka/pull/12174#discussion_r1549747480
##
core/src/main/scala/kafka/server/KafkaBroker.scala:
##
@@ -93,6 +93,7 @@ trait KafkaBroker extends Logging {
def startup(): Unit
def awaitShutdown(): Unit
soarez opened a new pull request, #12174:
URL: https://github.com/apache/kafka/pull/12174
When a controlled shutdown is requested the broker tries to communicate the
state change to the controller via a heartbeat request. [1]
In this test, the controller is not available so the
soarez closed pull request #12174: KAFKA-13907: Fix hanging
ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable
URL: https://github.com/apache/kafka/pull/12174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
16 matches
Mail list logo
