jolshan commented on code in PR #14607:
URL: https://github.com/apache/kafka/pull/14607#discussion_r1560454922
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFile.java:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software
junrao merged PR #14607:
URL: https://github.com/apache/kafka/pull/14607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1789288736
Thanks for triaging the transient test failures, @alok123t. Will merge the
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alok123t commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1788463950
@ijuma @junrao
the latest build succeeds for JDK 8/Scala 2.12. The previous failures should
be unrelated to this PR
alok123t commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1788460578
@junrao created following JIRA
https://issues.apache.org/jira/browse/KAFKA-15770
For rest of the failed tests, JIRA already exists
--
This is an automated message from the Apache
ijuma commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1783833262
I think this doesn't compile with Scala 2.12 - that needs to be fixed before
we can proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message,
alok123t commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1781801313
@junrao I think the test failures should be unrelated to the PR from a quick
look - not sure if these are known flaky tests, I will wait for another run
from the latest commit
--
alok123t commented on code in PR #14607:
URL: https://github.com/apache/kafka/pull/14607#discussion_r1373738648
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadata.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation
junrao commented on code in PR #14607:
URL: https://github.com/apache/kafka/pull/14607#discussion_r1373572075
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadata.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation
alok123t commented on code in PR #14607:
URL: https://github.com/apache/kafka/pull/14607#discussion_r1372811735
##
storage/src/main/java/org/apache/kafka/storage/internals/log/PartitionMetadataReadBuffer.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
junrao commented on code in PR #14607:
URL: https://github.com/apache/kafka/pull/14607#discussion_r1372393891
##
storage/src/main/java/org/apache/kafka/storage/internals/log/PartitionMetadataReadBuffer.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation
11 matches
Mail list logo
