dajac commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-2127911871
We will start this work from scratch. Closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac closed pull request #14327: KAFKA-14517: Implement regex subscriptions
URL: https://github.com/apache/kafka/pull/14327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-2094904127
Fyi @JimmyWang6, I have taken over this ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-2094886153
> hi @JimmyWang6, are you still working on this?
@Phuc-Hong-Tran I apologize for the delay in finishing this issue. I will
continue to work on this recently, and sorry for any
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1987118580
hi @JimmyWang6, are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1931122011
> Thanks for your reply！
> I will remove this part of code
@dajac
I'm sorry that I replied with the wrong content. Here is my email address:
Phuc-Hong-Tran commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1470890500
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1040,6 +1051,7 @@ private
CoordinatorResult consumerGr
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916373793
@dajac I miss-spelled the email, the correct one is phuctran3...@gmail.com
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dajac commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916361594
> @dajac Can you invite me to the apache slack as well? The email is
[phuctran3...@gamil.com](mailto:phuctran3...@gamil.com), TIA
@Phuc-Hong-Tran Done. You should receive an
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916356809
@dajac Can you invite me to the apache slack as well? The email is
phuctran3...@gamil.com, TIA
--
This is an automated message from the Apache Git Service.
To respond to the
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916021518
> h level comments to start with. Are you on the Apache slack? We could also
discuss there offline if you want.
@dajac
Thanks for your reply！
I will remove this part of
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916020627
> As a first step, it would be great if we could keep this pull request
focused on the RPC and its implementation on the server side. I would extract
the command line tool part into
Phuc-Hong-Tran commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1470370840
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1573,6 +1589,33 @@ private void updateGroupsByTopics(
dajac commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1469602233
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1573,6 +1589,33 @@ private void updateGroupsByTopics(
Phuc-Hong-Tran commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1469332580
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1573,6 +1589,33 @@ private void updateGroupsByTopics(
dajac commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1914230236
> @dajac I have a question regarding the usage of RE2J on the server side.
Shouldn't RE2J be the primary engine that will be used for compiling regular
expressions. Why is it not in the
dajac commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1469244568
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1040,6 +1051,7 @@ private
CoordinatorResult consumerGr
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1914228011
@dajac I have a question regarding the usage of RE2J on the server side.
Shouldn't RE2J be the primary engine that will be used for compiling regular
expressions. Why is it not in
dajac commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1914202236
As a first step, it would be great if we could keep this pull request
focused on the RPC and its implementation on the server side. I would extract
the command line tool part into its own
dajac commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1914199405
Hey @JimmyWang6. I am really sorry for the delay on this pull request. We
have too many other things to finish before I could really focus on it. I will
have more time in the coming weeks.
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1884289264
@dajac
I've updated the PR. Please take a look when you have a moment. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1880239109
Sure @JimmyWang6, but we need your PR to get merged first before we can
process with that task, otherwise whoever gonna work on that task need to fork
your branch, which is not an
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1880068864
> @JimmyWang6, are we still using re2j.Pattern for server-side regex
checking, I don't see its usage in the PR?
@Phuc-Hong-Tran The work to replace the existing regex matching
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1879985961
@JimmyWang6, are we still using re2j.Pattern for server-side regex checking,
I don't see its usage in the PR? Please correct if I missed something. Thanks
--
This is an
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1873362395
@
> @JimmyWang6 , I think for this part
>
> > What if a new topic gets created which matches the regex subscription of
some member.
>
> we need to use the metadata
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1817894315
@vamossagar12 Much thanks for your valuable comments! I apologize for the
delay in working on this issue for the reason that I have been occupied with
other commitments. I will fix
vamossagar12 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1801765565
@JimmyWang6 , Did you get a chance to go through the comments above? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vamossagar12 commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1376038092
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -669,7 +668,12 @@ private void
JimmyWang6 opened a new pull request, #14327:
URL: https://github.com/apache/kafka/pull/14327
This pull request implements the server-side functionality for regex
subscriptions in the next generation of the consumer rebalance protocol.
For the ConsumerGroupHeartbeat API, the server
vamossagar12 closed pull request #14327: KAFKA-14517:Implement regex
subscriptions
URL: https://github.com/apache/kafka/pull/14327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vamossagar12 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1780885517
@JimmyWang6 , I think for this part
> What if a new topic gets created which matches the regex subscription of
some member.
we need to use the metadata update mechanism
vamossagar12 commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1371564208
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -727,20 +728,42 @@ private void
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1777351686
@vamossagar12 @kirktrue @dajac
Hi everyone,
I kindly request your assistance in addressing the previous issue and
providing your valuable feedback. I appreciate your time and
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1760624540
Hi @dajac
Thank you for your feedback. I have just understood your point and realized
that there are indeed some issues with my code. I will make it a priority to
address them as
JimmyWang6 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1757298813
@dajac
Much Thanks for your review！
As for target assignment updates, the function
`maybeUpdateSubscribedTopicNames(oldMember, newMember)`
35 matches
Mail list logo
