fvaleri commented on PR #15273:
URL: https://github.com/apache/kafka/pull/15273#issuecomment-2025743216
Closing this one in favor of the work done for KAFKA-15853.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
fvaleri closed pull request #15273: KAFKA-14585: Refactoring for moving the
storage tool
URL: https://github.com/apache/kafka/pull/15273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706520
##
raft/src/main/java/org/apache/kafka/raft/RaftConfig.java:
##
@@ -206,6 +245,27 @@ private static Integer parseVoterId(String idString) {
}
}
+
showuon commented on PR #15273:
URL: https://github.com/apache/kafka/pull/15273#issuecomment-1920457353
> @showuon I rebased and addressed your comments. Did not remove properties
definitions from KafkaConfig, because this breaks a lot of tests. I think this
should be done as part of
fvaleri commented on PR #15273:
URL: https://github.com/apache/kafka/pull/15273#issuecomment-1918852761
@showuon I rebased and addressed your comments. Did not remove properties
definitions from KafkaConfig, because this breaks a lot of tests. I think this
should be done as part of
fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706520
##
raft/src/main/java/org/apache/kafka/raft/RaftConfig.java:
##
@@ -206,6 +245,27 @@ private static Integer parseVoterId(String idString) {
}
}
+
fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706520
##
raft/src/main/java/org/apache/kafka/raft/RaftConfig.java:
##
@@ -206,6 +245,27 @@ private static Integer parseVoterId(String idString) {
}
}
+
fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706370
##
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##
@@ -94,6 +94,18 @@ class LogConfigTest {
case TopicConfig.REMOTE_LOG_STORAGE_ENABLE_CONFIG =>
fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706370
##
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##
@@ -94,6 +94,18 @@ class LogConfigTest {
case TopicConfig.REMOTE_LOG_STORAGE_ENABLE_CONFIG =>
fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706683
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,6 +553,34 @@ public static Map configKeys() {
return
fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706253
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -290,7 +320,15 @@ public Optional serverConfigName(String
configName) {
showuon commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1470688447
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -290,7 +320,15 @@ public Optional serverConfigName(String
configName) {
fvaleri opened a new pull request, #15273:
URL: https://github.com/apache/kafka/pull/15273
Refactoring related to #14847.
The following properties are migrated from KafkaConfig (core):
- LogConfig (storage)
- log.dir
- logs.dirs
- metadata.log.dir
-
13 matches
Mail list logo
