chia7712 commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1986332391
@nizhikov nice patch. Let us go back to #14471 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 merged PR #15465:
URL: https://github.com/apache/kafka/pull/15465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nizhikov commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1985445590
@chia7712 I've checked CI results - looks like failures unrelated to PR
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nizhikov commented on code in PR #15465:
URL: https://github.com/apache/kafka/pull/15465#discussion_r1516639945
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -0,0 +1,622 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on code in PR #15465:
URL: https://github.com/apache/kafka/pull/15465#discussion_r1516631446
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -0,0 +1,622 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1983347482
Checked CI results. Failures unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nizhikov commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1982319460
@chia7712 PR merged with the latest trunk and ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1982055889
@nizhikov I'm ready to review this PR, so please rebase it. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nizhikov opened a new pull request, #15465:
URL: https://github.com/apache/kafka/pull/15465
This PR is part of https://github.com/apache/kafka/pull/14471
Is contains `ResetConsumerGroupOffsetTest` rewritten in java.
Intention of separate PR is to reduce changes and simplify review.
