nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2009012039
@chia7712 Please, take a look - https://github.com/apache/kafka/pull/15560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008956850
> The only issue I can see is naming.
Map.Entry has getKey, getValue for first and second values in pair which
sets some kind of relation between values for me.
While Tuple2 just
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008956417
@chia7712
@jolshan
@mimaison
@tledkov
Guys, thank you for a help with this PR!
--
This is an automated message from the Apache Git Service.
To respond to the
chia7712 merged PR #14471:
URL: https://github.com/apache/kafka/pull/14471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008931321
@chia7712 I tried to perform Tuple2 -> Map.Entry substitution.
The only issue I can see is naming.
`Map.Entry` has `getKey`, `getValue` for first and second values in pair
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008792236
@nizhikov thanks for all efforts! Please file PR to address follow-up,
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008700834
the failed test pass on my local:
```sh
./gradlew cleanTest :streams:test --tests
HighAvailabilityTaskAssignorIntegrationTest.shouldScaleOutWithWarmupTasksAndPersistentStores
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2007792800
@chia7712 I addressed all your comments. Please, take a look one more time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530832758
##
checkstyle/import-control.xml:
##
@@ -330,6 +330,7 @@
+
Review Comment:
This not required.
Sorry for that, should
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530815007
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/CsvUtils.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530813020
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -144,18 +145,18 @@ private void
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530807872
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -0,0 +1,1240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530718724
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -0,0 +1,1240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530708691
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -664,7 +664,7 @@ object TestUtils extends Logging {
* until the leader is elected and metadata is
chia7712 commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1530643112
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -664,7 +664,7 @@ object TestUtils extends Logging {
* until the leader is elected and metadata is
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2006340058
@chia7712 PR merged with the latest trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-2006320092
@nizhikov sorry for late review. could you rebase code and I will take a
look later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1999556511
Hello @mimaison , @jolshan
Do you have time to review this PR?
We are ready to move `ConsumerGroupCommand` to tools - all tests moved to
java, I've checked system tests and
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1999553646
> Are you suggesting to find more reviewers for this PR?
Yep, if they have free cycle
Anyway, I will take a look later. Thanks for updating code
--
This is an
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1999374812
@chia7712
I addressed all your comments. Please, take a look one more time.
> This is the last one and it is good time to give more reviews
Are you suggesting to
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525896298
##
bin/kafka-consumer-groups.sh:
##
@@ -14,4 +14,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-exec
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525874456
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -0,0 +1,1241 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525853816
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -0,0 +1,1241 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525852213
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/GroupState.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525847102
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/CsvUtils.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525842667
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/CsvUtils.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525841048
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -155,4 +157,17 @@ public static Set minus(Set set, T...toRemove) {
return res;
}
chia7712 commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1525644188
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/CsvUtils.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1992664069
@chia7712
I ran system tests for command, also.
System tests passed.
```
SESSION
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1522059985
##
build.gradle:
##
@@ -1999,10 +1999,14 @@ project(':tools') {
implementation project(':clients')
implementation project(':storage')
implementation
chia7712 commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1521936219
##
build.gradle:
##
@@ -1999,10 +1999,14 @@ project(':tools') {
implementation project(':clients')
implementation project(':storage')
implementation
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1990927207
@chia7712 CI looks OK for me. Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1986494220
@chia7712 PR merged with latest trunk and ready for review. Please, take a
look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1986332968
@nizhikov please rebase it. I feel we can complete this hard work this week
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976795668
Hello @mimaison @jolshan @showuon
I split PR even more and now all three PR's for a command test seems pretty
small.
Please, take a look if you have spare cycles.
#15365
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976741213
> There are two separate PR's that moves tests of command to tools:
oh, sorry that I did not notice that you have tried to make small PRs. will
take a look later.
> But, if
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976736579
> For example, we can have the new ConsumerGroupCommand supporting only
list, and then describe, delete, etc. And the last PR add deprecation
information and cleanup. WDYT?
I
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976721113
Hello @chia7712
Yes.
There are two separate PR's that moves tests of command to `tools`:
https://github.com/apache/kafka/pull/15365 - pretty small (+200, -100)
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1976703092
@nizhikov thanks for taking over this big issue. I'd like to give a review.
However, it is a bit huge. Is it possible to split this PR into small PRs by
the "command" of
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1942139254
Hello @mimaison @jolshan @showuon
I open two PR's to move the rest of `ConsoleGroupCommand` tests to tools.
#15365 - pretty small (+200, -100)
#15363 - relatively big,
jolshan commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1910847402
I have noticed several day builds for the project. I've alerted the mailing
thread, but will try to do some of my own investigation.
--
This is an automated message from the Apache Git
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1417877630
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/CsvUtils.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
tledkov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1417629458
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/CsvUtils.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
43 matches
Mail list logo
