Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-14 Thread via GitHub
chia7712 merged PR #15506: URL: https://github.com/apache/kafka/pull/15506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1523840166 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
chia7712 commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1523669497 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1523571839 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
gharris1727 commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1523535566 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-13 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1522917486 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-12 Thread via GitHub
hgeraldino commented on PR #15506: URL: https://github.com/apache/kafka/pull/15506#issuecomment-1992692291 Thanks @OmniaGM for your review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-12 Thread via GitHub
hgeraldino commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1522194636 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-12 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1521506327 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-12 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1521506327 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -1215,17 +1195,13 @@ public void testSuppressCloseErrors() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-12 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1521477925 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -580,12 +570,9 @@ public void

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-12 Thread via GitHub
OmniaGM commented on code in PR #15506: URL: https://github.com/apache/kafka/pull/15506#discussion_r1521475624 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -553,12 +547,8 @@ public void testErrorInRebalancePartitionLoss() {

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-11 Thread via GitHub
hgeraldino commented on PR #15506: URL: https://github.com/apache/kafka/pull/15506#issuecomment-1989568163 Thanks @chia7712 for your review @gharris1727 does this looks good to you? It's the final PR to consider the `WorkerSinkTaskTest` migration done done -- This is an automated

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-10 Thread via GitHub
hgeraldino commented on PR #15506: URL: https://github.com/apache/kafka/pull/15506#issuecomment-1987243289 > @hgeraldino thank for this patch. Could you please apply `assertThrow` to this class? For example, the following assert can be rewritten. _origin_ > > ```java > try