Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-24 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1613033249 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-24 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1612931258 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-23 Thread via GitHub
showuon commented on PR #15625: URL: https://github.com/apache/kafka/pull/15625#issuecomment-2126707276 @abhijeetk88 , do we have any update on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597682003 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -181,7 +189,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597667627 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597667613 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597666914 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597664809 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-03 Thread via GitHub
junrao commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1589688863 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -181,7 +189,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-03 Thread via GitHub
showuon commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1588939433 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig {

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-26 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1580557688 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-26 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1580549399 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-26 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1580545776 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-25 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1580515079 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-25 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1580499863 ## core/src/test/java/kafka/log/remote/quota/RLMQuotaManagerTest.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-24 Thread via GitHub
kamalcph commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1577552070 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-23 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1576007574 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## Review Comment: Yes, the integration of the quota manager will come in the follow-up

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-23 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1576005665 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-19 Thread via GitHub
funky-eyes commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1572073595 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## Review Comment: I have a question, in fact, what this PR does is to provide a standard

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-04-15 Thread via GitHub
HenryCaiHaiying commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1566566286 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or