mjsax commented on code in PR #14448:
URL: https://github.com/apache/kafka/pull/14448#discussion_r1605892956
##
docs/streams/developer-guide/config-streams.html:
##
@@ -261,10 +261,10 @@ num.standby.replicasstatestore.cache.max.bytes
Medium
-Maximum
mjsax commented on PR #14448:
URL: https://github.com/apache/kafka/pull/14448#issuecomment-2114112274
@Cerchie -- this PR would need a rebase as #14360 was merged. Also, seems we
introduced a few JavaDoc issues (cf
https://github.com/apache/kafka/pull/14360#issuecomment-2108456039) that we
Cerchie commented on PR #14448:
URL: https://github.com/apache/kafka/pull/14448#issuecomment-2087251352
tagging @mjsax in for re-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Cerchie commented on code in PR #14448:
URL: https://github.com/apache/kafka/pull/14448#discussion_r1580062597
##
.github/workflows/codesee-arch-diagram.yml:
##
@@ -0,0 +1,23 @@
+# This workflow was added by CodeSee. Learn more at https://codesee.io/
Review Comment:
removed
mjsax commented on code in PR #14448:
URL: https://github.com/apache/kafka/pull/14448#discussion_r1508427425
##
.github/workflows/codesee-arch-diagram.yml:
##
@@ -0,0 +1,23 @@
+# This workflow was added by CodeSee. Learn more at https://codesee.io/
Review Comment:
I don't
Cerchie commented on PR #14448:
URL: https://github.com/apache/kafka/pull/14448#issuecomment-1959710205
> Thanks for the PR. Overall LGTM.
>
> I am just wondering if we should also update the JavaDocs for all
deprecated configs? For example:
>
> ```
> /** {@code
mjsax commented on PR #14448:
URL: https://github.com/apache/kafka/pull/14448#issuecomment-1897502404
Thanks for the PR. Overall LGTM.
I am just wondering if we should also update the JavaDocs for all deprecated
configs? For example:
```
/** {@code
github-actions[bot] commented on PR #14448:
URL: https://github.com/apache/kafka/pull/14448#issuecomment-1868700701
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
