Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

github-actions[bot] commented on PR #14957: URL: https://github.com/apache/kafka/pull/14957#issuecomment-1998877709 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424277821 ## streams/src/test/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValueTest.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424265799 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -69,23 +73,49 @@ public boolean hasNext() { if

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424265799 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -69,23 +73,49 @@ public boolean hasNext() { if

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424245975 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424136033 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

mjsax commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424208309 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

mjsax commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424208309 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

mjsax commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424206051 ## streams/src/test/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValueTest.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424138349 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424136033 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424138349 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1424055579 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -100,34 +130,48 @@ private boolean maybeFillIterator() {

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

mjsax commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1423917600 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -100,34 +130,48 @@ private boolean maybeFillIterator() {

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1422488101 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

mjsax commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1422442823 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1421149432 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -340,32 +355,67 @@ public

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on PR #14957: URL: https://github.com/apache/kafka/pull/14957#issuecomment-1848005381 @mjsax I modified the `find()` method in the best possible way reusing the currently defined `deserIndex` and caches. Here is a brief list of changes and issues. 1. I had to

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420974212 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -340,32 +355,67 @@ public

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420648455 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -340,32 +355,67 @@ public

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420641426 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -340,32 +355,67 @@ public

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420471301 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -150,7 +152,15 @@ interface SegmentValue

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420466908 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -150,7 +152,15 @@ interface SegmentValue

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420462098 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -266,6 +276,11 @@ private static class

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420464501 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -266,6 +276,11 @@ private static class

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420462098 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -266,6 +276,11 @@ private static class

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420452896 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -100,34 +134,49 @@ private boolean maybeFillIterator() {

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

mjsax commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420058690 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -69,23 +76,50 @@ public boolean hasNext() { if (!open) {

Re: [PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

mjsax commented on code in PR #14957: URL: https://github.com/apache/kafka/pull/14957#discussion_r1420051909 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java: ## @@ -34,7 +31,16 @@ public class LogicalSegmentIterator implements

[PR] KAFKA-15347: implement lazy deserialization for segment [kafka]

aliehsaeedii opened a new pull request, #14957: URL: https://github.com/apache/kafka/pull/14957 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of