showuon commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1999010980
Sorry that I missed the ping. Thanks Satish for helping review. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
satishd merged PR #15490:
URL: https://github.com/apache/kafka/pull/15490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
satishd commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1998903881
Failing tests are unrelated to this change, merging it to 3.6 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
divijvaidya commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1985969718
@showuon can you please take a look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
divijvaidya commented on PR #15490:
URL: https://github.com/apache/kafka/pull/15490#issuecomment-1985969187
The failing tests are known to be flaky for 3.6 branch, e,g,
https://ge.apache.org/scans/tests?search.relativeStartTime=P28D=kafka=3.6=Europe%2FBerlin=kafka.server.KRaftClusterTest
gaurav-narula commented on code in PR #15490:
URL: https://github.com/apache/kafka/pull/15490#discussion_r1516423400
##
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##
@@ -154,6 +159,25 @@ class KafkaServerTest extends QuorumTestHarness {
server.shutdown()
gaurav-narula commented on code in PR #15490:
URL: https://github.com/apache/kafka/pull/15490#discussion_r1516423400
##
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##
@@ -154,6 +159,25 @@ class KafkaServerTest extends QuorumTestHarness {
server.shutdown()
divijvaidya opened a new pull request, #15490:
URL: https://github.com/apache/kafka/pull/15490
## Bug
On startup, Kafka creates a checkpoint for broker metadata. If underlying
storage throws an IOException for any reason (maybe disk is full), then Kafka
should mark the directory as
