Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

mumrah merged PR #15470: URL: https://github.com/apache/kafka/pull/15470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on PR #15470: URL: https://github.com/apache/kafka/pull/15470#issuecomment-2040217099 @mumrah Thanks for the review. Ticket filed. https://issues.apache.org/jira/browse/KAFKA-15579 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

mumrah commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1551680241 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2185,157 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1544749533 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2184,155 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

mumrah commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1544478846 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2184,155 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1526696015 ## tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java: ## @@ -639,6 +639,25 @@ public void testDescribe(String quorum) throws

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1526695825 ## tools/src/main/java/org/apache/kafka/tools/TopicCommand.java: ## @@ -799,6 +820,11 @@ public TopicCommandOptions(String[] args) { "if set

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1526695578 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1526690281 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1526685631 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2256,6 +2384,26 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1526680281 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

mumrah commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1526390858 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1523996339 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2185,9 +2179,144 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1523971792 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1523702932 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1520495884 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1520498085 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1520495884 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1520443872 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1516873731 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,138 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1515290353 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,138 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1515289272 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,138 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1515288246 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2177,122 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513820234 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2177,122 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1515057898 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -1399,6 +1404,184 @@ public void testInvalidTopicNames() throws

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1515057124 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2276,6 +2415,11 @@ private Node leader(PartitionInfo partitionInfo) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

AndrewJSchofield commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1514119801 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2276,6 +2415,11 @@ private Node leader(PartitionInfo partitionInfo) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

AndrewJSchofield commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1514117940 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -1399,6 +1404,184 @@ public void testInvalidTopicNames() throws

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

dajac commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1514092183 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2276,6 +2399,11 @@ private Node leader(PartitionInfo partitionInfo) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513643851 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,32 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513646133 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2276,6 +2415,11 @@ private Node leader(PartitionInfo partitionInfo) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513643851 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,32 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513641333 ## tools/src/main/java/org/apache/kafka/tools/TopicCommand.java: ## @@ -799,6 +823,11 @@ public TopicCommandOptions(String[] args) { "if set

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513641009 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -1399,6 +1404,184 @@ public void testInvalidTopicNames() throws

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513640718 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2190,6 +2201,117 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513640577 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,32 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513640434 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,32 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

kirktrue commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513390603 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,32 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

dajac commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513322953 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,32 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

dajac commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513322953 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,32 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

AndrewJSchofield commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1513310569 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2190,6 +2201,117 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent commented on PR #15470: URL: https://github.com/apache/kafka/pull/15470#issuecomment-1977980848 As discussed offline, we decided not to implement the pagination handling in this ticket. Here is the load-all-in-memory version to the https://github.com/apache/kafka/pull/15265

[PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

CalvinConfluent opened a new pull request, #15470: URL: https://github.com/apache/kafka/pull/15470 https://issues.apache.org/jira/browse/KAFKA-15585 Add the support for DescribeTopicPartitions API on the client side. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

artemlivshits commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1506982605 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2276,6 +2337,141 @@ private Node leader(PartitionInfo partitionInfo) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

kirktrue commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1506743625 ## clients/src/main/java/org/apache/kafka/common/TopicPartitionInfo.java: ## @@ -79,9 +95,24 @@ public List isr() { return isr; } +/** + *

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

kirktrue commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1506629098 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -335,6 +335,21 @@ default DescribeTopicsResult describeTopics(TopicCollection topics) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1505044853 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -994,6 +1002,36 @@ public boolean isInternal() { } } +

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1505044493 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,25 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1505044242 ## clients/src/main/java/org/apache/kafka/common/TopicPartitionInfo.java: ## @@ -79,9 +95,24 @@ public List isr() { return isr; } +/** +

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1505043369 ## tools/src/main/java/org/apache/kafka/tools/TopicCommand.java: ## @@ -558,20 +568,53 @@ public void describeTopic(TopicCommandOptions opts) throws

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1505039131 ## tools/src/main/java/org/apache/kafka/tools/TopicCommand.java: ## @@ -558,20 +568,53 @@ public void describeTopic(TopicCommandOptions opts) throws

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1505035988 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java: ## @@ -36,28 +38,38 @@ public class DescribeTopicsResult { private

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

kirktrue commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1503266038 ## clients/src/main/java/org/apache/kafka/common/TopicPartitionInfo.java: ## @@ -79,9 +95,24 @@ public List isr() { return isr; } +/** + *

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

kirktrue commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1503175975 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java: ## @@ -47,8 +49,25 @@ public DescribeTopicsOptions

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

artemlivshits commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1501002625 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2129,63 +2167,183 @@ private Map> handleDescribeTopicsByNames(f

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1499752721 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2108,9 +2146,12 @@ void handleFailure(Throwable throwable) { public

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

mumrah commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1497780170 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2129,63 +2167,183 @@ private Map> handleDescribeTopicsByNames(f }

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1496355495 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2129,63 +2167,183 @@ private Map> handleDescribeTopicsByNames(f

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

artemlivshits commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1495047191 ## clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java: ## @@ -36,28 +38,38 @@ public class DescribeTopicsResult { private final

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

artemlivshits commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1491416954 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2129,63 +2167,183 @@ private Map> handleDescribeTopicsByNames(f

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

mumrah commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1489713255 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2129,63 +2167,183 @@ private Map> handleDescribeTopicsByNames(f }

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

artemlivshits commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1476922434 ## tools/src/main/java/org/apache/kafka/tools/TopicCommand.java: ## @@ -799,6 +814,13 @@ public TopicCommandOptions(String[] args) { "if set

[PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

CalvinConfluent opened a new pull request, #15265: URL: https://github.com/apache/kafka/pull/15265 https://issues.apache.org/jira/browse/KAFKA-15585 Add the support for DescribeTopicPartitions API on the client side. -- This is an automated message from the Apache Git Service. To