appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580562449
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -326,22 +326,34 @@ private void handleInitializeErrors(final
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2101717211
@lianetm & @philipnee If you have a moment, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kirktrue commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2091362381
@lianetm & @philipnee—would you be able to review this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580504115
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580510829
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -327,21 +327,27 @@ private void handleInitializeErrors(final
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580510829
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -327,21 +327,27 @@ private void handleInitializeErrors(final
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580510829
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -327,21 +327,27 @@ private void handleInitializeErrors(final
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580504115
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580499797
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580504115
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
appchemist commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580499797
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -200,6 +200,9 @@ protected void handleFetchSuccess(final Node
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2078650601
Thanks for review! @kirktrue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kirktrue commented on code in PR #15647:
URL: https://github.com/apache/kafka/pull/15647#discussion_r1580103763
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##
@@ -327,21 +327,27 @@ private void handleInitializeErrors(final
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2073683927
@kirktrue Thanks for the heads-up!
If you have a moment, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kirktrue commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2073652156
@appchemist—thanks for the PR, and sorry for the delay in response!
I've taken a first pass but am still working through the unit test changes.
--
This is an automated message
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2067889913
@kirktrue, PTAL, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2057454239
> thanks for the PR! just curious, what is the problem without the newly
added state? does it cause any issues?
@johnnychhsu
When a kafka consumer encounters a
johnnychhsu commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2057103180
thanks for the PR!
just curious, what is the problem without the newly added state? does it
cause any issues?
--
This is an automated message from the Apache Git Service.
To
appchemist opened a new pull request, #15647:
URL: https://github.com/apache/kafka/pull/15647
- add 'AWAIT_UPDATE' state in FetchStates
- This state makes the subscription unfetchable during metadata updates.
- After a metadata update, the state becomes 'AWAIT_VALIDATION' or
19 matches
Mail list logo
