Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2024-04-04 Thread via GitHub
github-actions[bot] commented on PR #14666: URL: https://github.com/apache/kafka/pull/14666#issuecomment-2038787933 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2024-01-05 Thread via GitHub
vamossagar12 commented on PR #14666: URL: https://github.com/apache/kafka/pull/14666#issuecomment-1878869619 hey @divijvaidya , @showuon would you be able to review this PR? This seems like a useful change and things look fine once I reviewed. -- This is an automated message from the

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-11-29 Thread via GitHub
Lucent-Wong commented on PR #14666: URL: https://github.com/apache/kafka/pull/14666#issuecomment-1833071663 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-11-21 Thread via GitHub
Lucent-Wong commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1400935789 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala: ## @@ -3782,6 +3784,33 @@ class GroupCoordinatorTest {

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-11-21 Thread via GitHub
vamossagar12 commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1400864801 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala: ## @@ -3782,6 +3784,33 @@ class GroupCoordinatorTest {

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-11-20 Thread via GitHub
Lucent-Wong commented on PR #14666: URL: https://github.com/apache/kafka/pull/14666#issuecomment-1819365201 re-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-10-30 Thread via GitHub
Lucent-Wong commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1376291255 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1335,7 +1339,7 @@ private[group] class GroupCoordinator( // Failed

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-10-30 Thread via GitHub
vamossagar12 commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1375947390 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala: ## @@ -609,7 +609,7 @@ class GroupMetadataTest { @Test def

Re: [PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-10-30 Thread via GitHub
vamossagar12 commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1375947390 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala: ## @@ -609,7 +609,7 @@ class GroupMetadataTest { @Test def

[PR] KAFKA-15704: Update clientId and clientHost in MemberMetadata when static member is replaced. [kafka]

2023-10-30 Thread via GitHub
Lucent-Wong opened a new pull request, #14666: URL: https://github.com/apache/kafka/pull/14666 Problem statement: In static membership protocol, the clientId and clientHost are not changed when static member is replaced. This will make it confused for user when describe the