chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2054058198
failed tests pass on my local. will merge it.
```
./gradlew cleanTest :streams:test --tests
SlidingWindowedKStreamIntegrationTest.shouldRestoreAfterJoinRestart --tests
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2054058383
@Owen-CH-Leung thanks for your contribution and effort!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 merged PR #15489:
URL: https://github.com/apache/kafka/pull/15489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1564488318
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,7 +53,7 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1564147419
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,7 +53,7 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1564142762
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,7 +53,7 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1564142762
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,7 +53,7 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1564099443
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,7 +53,7 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2053607875
> @Owen-CH-Leung
>
> The root cause is that not all produce records succeed to be sent, and we
don't check all sends before closing producer. As our CI is very busy, it could
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1562683822
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +428,30 @@ private String[] addBootstrapServer(String... args) {
return
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2042555906
> Look like the build still contains failed test :(
yep, I have filed another #15654 to dig in that :_
--
This is an automated message from the Apache Git Service.
To respond to
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2042547986
> rebase to trigger QA again
Look like the build still contains failed test :(
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2041136463
rebase to trigger QA again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2038933841
blocked by #15663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1550273635
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {
return
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1550273635
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {
return
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1548103258
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1548067397
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {
return
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1548061572
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1547986293
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {
return
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1547934887
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {
return
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1547789497
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1547302390
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1547303323
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -94,15 +101,47 @@ private void setUp() {
}
}
+private void
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1547302390
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1546808904
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -94,15 +101,47 @@ private void setUp() {
}
}
+private void
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1546808666
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {
return
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2029635510
> > Shall we just add the retry logic for tests that perform assertion based
on the Row class ?
>
> yep, `waitForCondition` can address that for you :)
Ok. I've
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2029493994
> Shall we just add the retry logic for tests that perform assertion based
on the Row class ?
yep, `waitForCondition` can address that for you :)
--
This is an automated
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2029487529
> assertEquals(expectedTestTopicOffsets().stream().filter(r -> r.partition
<= 1).collect(Collectors.toList()), offsets);
Oh got it. I read through the previous CI failure and
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2028866594
> Sure. I've used waitForCondition to wait for __consumer_offsets to be
created when creating consumers to poll
I meant `assertEquals(expectedTestTopicOffsets().stream().filter(r
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2028580025
> @Owen-CH-Leung Could you use `TestUtils.waitForCondition` to verify the
records? maybe our QA is too slow to update the metadata before we do the check
Sure. I've used
mcmmining commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2028548626
> > printUsageAndExit
>
> Agree. Setting a dumb exit procedure solves the failed build. Let me
revise that
--
This is an automated message from the Apache Git
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2028541632
@Owen-CH-Leung Could you use `TestUtils.waitForCondition` to verify the
records? maybe our QA is too slow to update the metadata before we do the check
--
This is an automated message
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2028041612
rebase code to include the fix
https://github.com/apache/kafka/commit/9a9b532d5d5beeecf7a4b769731ee609625429e1
--
This is an automated message from the Apache Git Service.
To respond
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1545199583
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1545074098
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1545058512
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1544639778
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1544636515
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1544483152
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2026412628
> adde167
No prob. Added back `ToString` to troubleshoot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2025290627
@Owen-CH-Leung Could you add `toString` back? It seems the test is unstable
and we need to dig in it :)
--
This is an automated message from the Apache Git Service.
To respond to the
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1542557448
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,13 +52,14 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1542532419
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -48,13 +52,14 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2024287098
> printUsageAndExit
Agree. Setting a dumb exit procedure solves the failed build. Let me revise
that
--
This is an automated message from the Apache Git Service.
To
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2023109755
@Owen-CH-Leung The `printUsageAndExit` call `exit(1)` so `KRAFT` and
`CO_KRAFT` will stop the JVM. `ZK` can capture the exit code to throw exception
so it does not terminate the JVM.
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2020499827
It seems all builds failed due to `tools` module. Could you check them
please?
```
[2024-03-26T11:58:09.997Z] Execution failed for task ':tools:test'.
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2019613861
@Owen-CH-Leung Could you please rebase code to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1537117543
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -47,14 +51,16 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1537094676
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -47,14 +51,16 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1537089434
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -283,7 +318,7 @@ public void testTopicPartitionsArgWithInternalExcluded() {
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1536623947
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -338,6 +373,7 @@ private void assertExitCodeIsOne(String... args) {
}
private
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1534974289
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -182,14 +187,19 @@ public void testTopicPartitionsArg() {
setUp();
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1534178664
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -182,14 +187,19 @@ public void testTopicPartitionsArg() {
setUp();
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1534175100
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -182,14 +187,19 @@ public void testTopicPartitionsArg() {
setUp();
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1534168170
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -338,6 +348,10 @@ private void assertExitCodeIsOne(String... args) {
}
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1534166771
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -182,14 +187,19 @@ public void testTopicPartitionsArg() {
setUp();
Owen-CH-Leung commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1534165905
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1533239354
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -182,14 +187,19 @@ public void testTopicPartitionsArg() {
setUp();
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1533209761
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {
Owen-CH-Leung opened a new pull request, #15489:
URL: https://github.com/apache/kafka/pull/15489
https://issues.apache.org/jira/browse/KAFKA-15729
As per [KAFKA-15729](https://issues.apache.org/jira/browse/KAFKA-15729),
this PR adds Kraft support to `GetOffsetShellTest`
62 matches
Mail list logo
