Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

2024-03-31 Thread via GitHub
showuon merged PR #14760: URL: https://github.com/apache/kafka/pull/14760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

2024-03-31 Thread via GitHub
showuon commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-2029112501 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

2024-03-31 Thread via GitHub
gaurav-narula commented on code in PR #14760: URL: https://github.com/apache/kafka/pull/14760#discussion_r1545653758 ## core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala: ## @@ -386,6 +386,7 @@ class NodeToControllerRequestThread( if

Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

2024-03-28 Thread via GitHub
showuon commented on code in PR #14760: URL: https://github.com/apache/kafka/pull/14760#discussion_r1544017066 ## core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala: ## @@ -386,6 +386,7 @@ class NodeToControllerRequestThread( if

Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

2024-03-28 Thread via GitHub
soarez commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-2026260420 This still needs a review from a committer. @mimaison @mumrah @rondagostino @showuon -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

2024-02-22 Thread via GitHub
github-actions[bot] commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-1960687556 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

2023-11-23 Thread via GitHub
gaurav-narula commented on PR #14760: URL: https://github.com/apache/kafka/pull/14760#issuecomment-1825242721 CC: @hachikuji since you've looked into the response handler recently. Can you please review this PR? -- This is an automated message from the Apache Git Service. To respond to

[PR] KAFKA-15823: disconnect from controller on AuthenticationException [kafka]

2023-11-14 Thread via GitHub
gaurav-narula opened a new pull request, #14760: URL: https://github.com/apache/kafka/pull/14760 This PR changes the handling of authenticationException on a request from the node to the controller. We disconnect controller connection and invalidate the cache so that the next run of