OmniaGM commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-2126925294
> @OmniaGM Are you still working on moving KafkaConfig out of core? Can you,
please, show me PR's you are currently working on regarding KafkaConfig?
I was about to open a pr for
nizhikov commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-2126366162
@OmniaGM Are you still working on moving KafkaConfig out of core?
Can you, please, show me PR's you are currently working on regarding
KafkaConfig?
--
This is an automated message
OmniaGM closed pull request #15501: KAFKA-15853: Move KafkaConfig properties
definition out of core
URL: https://github.com/apache/kafka/pull/15501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
OmniaGM commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-2061520938
Am going to close this one as it drifted away from the approach we took to
break the configs out.
--
This is an automated message from the Apache Git Service.
To respond to the
nizhikov commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-2008920265
@OmniaGM
> Start doing this but will be continue this after the Kafka Summit London.
Great! Don't hesitate to ask for assistance if you need any help.
--
This is an
OmniaGM commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-2008054490
> Hello @OmniaGM
>
>
>
> Are you be able to split this PR in several to simplify review and merge?
>
> My jira https://issues.apache.org/jira/browse/KAFKA-14588
nizhikov commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-2007922919
Hello @OmniaGM
Are you be able to split this PR in several to simplify review and merge?
My jira https://issues.apache.org/jira/browse/KAFKA-14588 blocked by
migration
nizhikov commented on PR #15501:
URL: https://github.com/apache/kafka/pull/15501#issuecomment-1999413290
Hello @OmniaGM
I think this PR still too big for one change.
Can we split it?
We can start with LogConfiguration:
```
/** * Log Configuration
OmniaGM opened a new pull request, #15501:
URL: https://github.com/apache/kafka/pull/15501
Moving KafkaConfig props out of core. The pr is big however it's mostly
renaming the props to match Java constant patterns and switching to
`org.apache.kafka.server.config.KafkaConfig` instead of the
