Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-20 Thread via GitHub
chia7712 commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1573199471 ## server/src/main/java/org/apache/kafka/server/config/KafkaSecurityConfigs.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-20 Thread via GitHub
chia7712 commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1573179046 ## server/src/main/java/org/apache/kafka/server/config/KafkaSecurityConfigs.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-19 Thread via GitHub
omkreddy commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1573153281 ## server/src/main/java/org/apache/kafka/server/config/KafkaSecurityConfigs.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-10 Thread via GitHub
chia7712 merged PR #15656: URL: https://github.com/apache/kafka/pull/15656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15656: URL: https://github.com/apache/kafka/pull/15656#issuecomment-2044920363 @OmniaGM Could you fix the build error? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
chia7712 commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1556371500 ## server/src/main/java/org/apache/kafka/server/config/KafkaSecurityConfigs.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
OmniaGM commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1556357170 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
chia7712 commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1556226896 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
OmniaGM commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1555878104 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
OmniaGM commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1555878104 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
OmniaGM commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1555878104 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
OmniaGM commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1555869666 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
OmniaGM commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1555869666 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-08 Thread via GitHub
OmniaGM commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1555869666 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1554518847 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-04 Thread via GitHub
OmniaGM commented on PR #15656: URL: https://github.com/apache/kafka/pull/15656#issuecomment-2037325362 @nizhikov can you have a look when you have time please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-04 Thread via GitHub
OmniaGM opened a new pull request, #15656: URL: https://github.com/apache/kafka/pull/15656 part 3 for https://github.com/apache/kafka/pull/15501 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build