Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on PR #15572: URL: https://github.com/apache/kafka/pull/15572#issuecomment-2025466888 @OmniaGM @chia7712 @ijuma CI seems OK for me. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542637640 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1675,6 +1675,15 @@ public static Map entriesWithPrefix(Map map, String pr return

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542631664 ## core/src/main/scala/kafka/zk/ZkData.scala: ## @@ -757,8 +757,8 @@ case object ExtendedAclChangeStore extends ZkAclChangeStore { object ResourceZNode { def

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542627362 ## core/src/main/scala/kafka/admin/AclCommand.scala: ## @@ -486,7 +486,8 @@ object AclCommand extends Logging { private def validateOperation(opts:

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542620928 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

chia7712 commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542590608 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542478487 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542518584 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542488524 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542486534 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542478487 ## server-common/src/main/java/org/apache/kafka/server/util/Utils.java: ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on PR #15572: URL: https://github.com/apache/kafka/pull/15572#issuecomment-2024577072 @OmniaGM @ijuma All comments resolved. Please, take a look one more time. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1542439635 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

ijuma commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541513692 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541508048 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541492785 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

ijuma commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541483681 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541475816 ## core/src/test/scala/integration/kafka/api/BaseAdminIntegrationTest.scala: ## @@ -183,12 +184,13 @@ abstract class BaseAdminIntegrationTest extends

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541472627 ## server/src/main/java/org/apache/kafka/security/CredentialProvider.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541471761 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

OmniaGM commented on code in PR #15572: URL: https://github.com/apache/kafka/pull/15572#discussion_r1541382798 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov commented on PR #15572: URL: https://github.com/apache/kafka/pull/15572#issuecomment-2013016349 Hello, @ijuma I moved two of three `kafka.security` classes to `server` - `AclEntry`, `CredentialProvider`. Third one - `AclAuthorizer` quite big and have some dependencies on

[PR] KAFKA-15899 Move kafka.security package from core to server module [kafka]

nizhikov opened a new pull request, #15572: URL: https://github.com/apache/kafka/pull/15572 This PR moves `kafka.security` classes from `core` to `server` module. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test