Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-04-05 Thread via GitHub
viktorsomogyi commented on PR #15605: URL: https://github.com/apache/kafka/pull/15605#issuecomment-2039754554 Aslo, thank you @akatona84 for the contribution, @soarez and @urbandan for the reviews. Fixing flaky tests is always very welcomed, keep it up!  -- This is an automated message

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-04-05 Thread via GitHub
viktorsomogyi merged PR #15605: URL: https://github.com/apache/kafka/pull/15605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-29 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1544810115 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,32 @@ import org.mockito.Mockito.{mock, when} import

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-28 Thread via GitHub
soarez commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1543761783 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,32 @@ import org.mockito.Mockito.{mock, when} import

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541384909 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541384909 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541378249 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
soarez commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541375369 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,22 +38,49 @@ import org.mockito.Mockito.{mock, when} import

Re: [PR] KAFKA-15915: Flaky ProducerIdManagerTest error injection fix [kafka]

2024-03-27 Thread via GitHub
akatona84 commented on code in PR #15605: URL: https://github.com/apache/kafka/pull/15605#discussion_r1541357369 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when} import