showuon commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2126963749
@jeqo , could you address @kamalcph 's comment above? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kamalcph commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2074186450
Thanks for the patch @jeqo!
I was able to reproduce the exception mentioned in the ticket by calling
close in-middle of collecting the aborted transactions. The fix doesn't
nikramakrishnan commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2072530250
Bump! @satishd @kamalcph can we get this review going? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nikramakrishnan commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1509082067
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -522,6 +522,18 @@ public TimeIndex timeIndex() {
//
nikramakrishnan commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1509082067
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -522,6 +522,18 @@ public TimeIndex timeIndex() {
//
jeqo opened a new pull request, #15241:
URL: https://github.com/apache/kafka/pull/15241
Cached TransactionIndex may get closed if interrupted, causing following
calls to always fail with ClosedChannelException, and forcing process to be
restarted. In order to avoid this issue, a new method
