junrao merged PR #14903:
URL: https://github.com/apache/kafka/pull/14903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-2018530584
@soarez : Thanks for triaging the test failures. Will merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-2018506864
@junrao all the failed tests are being tracked.
These were already tracked:
* KAFKA-8041
kafka.server.LogDirFailureTest.testIOExceptionDuringCheckpoint(String).quorum=kraft
junrao commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-2018408733
@soarez : Are the failed tests in the latest run being tracked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-2014828308
Hey @junrao . Sorry I didn't reply about the failing tests earlier, I was
still looking into it and should've made that clear.
I had a look at the test results. It's strange that
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1534216092
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -254,33 +262,41 @@ class BrokerLifecycleManagerTest {
@Test
def
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1532500641
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -254,33 +262,41 @@ class BrokerLifecycleManagerTest {
@Test
def
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1531683586
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -197,11 +197,17 @@ class BrokerLifecycleManagerTest {
result
}
- def
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1531683014
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -254,33 +261,38 @@ class BrokerLifecycleManagerTest {
@Test
def
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1530918656
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -254,33 +261,38 @@ class BrokerLifecycleManagerTest {
@Test
def
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-2006292277
Thanks for the review @junrao. Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1529927411
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -197,11 +197,17 @@ class BrokerLifecycleManagerTest {
result
}
- def
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1529919190
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -219,15 +225,16 @@ class BrokerLifecycleManagerTest {
Collections.emptyMap(),
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1526788841
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -551,9 +580,11 @@ class BrokerLifecycleManager(
}
private def
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1998592089
Rebased this due to merge conflict.
@gaurav-narula I also made what I believe are some improvement to
`BrokerLifecycleManagerTest.testKraftJBODMetadataVersionUpdateEvent`, can you
github-actions[bot] commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1987577154
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
rondagostino commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1850988044
`12 tests have failed. There are 12 new tests failing, 0 existing failing`
I think this PR can be merged now assuming @cmccabe takes a look at the
question above regarding
OmniaGM commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1850387349
> `51 tests have failed. There are 49 new tests failing, 2 existing failing`
>
> This seems like a lot more failures than we are used to recently. @OmniaGM
Can you rebase this onto
rondagostino commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1850245547
`51 tests have failed. There are 49 new tests failing, 2 existing failing`
This seems like a lot more failures than we are used to recently. @OmniaGM
Can you rebase this
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1843813913
@junrao: Thanks for revewing this. It seems there are currently some issues
with faling tests. See
https://github.com/apache/kafka/pull/14838#issuecomment-1843693525
The test failures
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417911671
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -364,10 +377,30 @@ class BrokerLifecycleManager(
}
_channelManager.sendRequest(new
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417143188
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -513,4 +513,28 @@ public void close() throws InterruptedException {
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417129195
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -513,4 +513,28 @@ public void close() throws InterruptedException {
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417124246
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -513,4 +513,28 @@ public void close() throws InterruptedException {
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417121867
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -197,11 +197,14 @@ class BrokerLifecycleManagerTest {
result
}
- def
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417116727
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1416090404
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1415408700
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1839871090
@cmccabe thanks for having a look.
I've made the following changes:
* Replaced the use of `prepend` with `append` in `propagateDirectoryFailure`
* Moved
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414728861
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -197,11 +197,14 @@ class BrokerLifecycleManagerTest {
result
}
- def
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414711941
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -366,8 +379,27 @@ class BrokerLifecycleManager(
new BrokerRegistrationResponseHandler())
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414708239
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -366,8 +379,27 @@ class BrokerLifecycleManager(
new BrokerRegistrationResponseHandler())
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414704903
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+
cmccabe commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1839768073
> Instead, CommunicationEvent.run() should gracefully handle running when
communicationInFlight = true Probably by doing nothing.
This also implies that
cmccabe commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1839747217
Thanks for looking at this, @soarez .
I don't think `nextSchedulingShouldBeImmediate` should be reset to false
until the `CommunicationEvent` is run.
I also think we should
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414647339
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414633539
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -453,79 +490,73 @@ class BrokerLifecycleManager(
val message =
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414626881
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -366,8 +379,27 @@ class BrokerLifecycleManager(
new BrokerRegistrationResponseHandler())
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414322506
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -197,11 +197,14 @@ class BrokerLifecycleManagerTest {
result
}
- def
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1837447759
@junrao: please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
soarez opened a new pull request, #14903:
URL: https://github.com/apache/kafka/pull/14903
In between HeartbeatRequest being sent and the response being handled, i.e.
while a HeartbeatRequest is in flight, an extra request may be immediately
scheduled if propagateDirectoryFailure,
41 matches
Mail list logo
