cadonna merged PR #15669:
URL: https://github.com/apache/kafka/pull/15669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm commented on PR #15669:
URL: https://github.com/apache/kafka/pull/15669#issuecomment-2045510642
Thanks @cadonna! fixed it in the entire file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cadonna commented on PR #15669:
URL: https://github.com/apache/kafka/pull/15669#issuecomment-2045435265
@lianetm I found the same typo throughout the test class. Do you want to fix
it in the entire file?
--
This is an automated message from the Apache Git Service.
To respond to the
cadonna commented on code in PR #15669:
URL: https://github.com/apache/kafka/pull/15669#discussion_r1557825632
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -498,6 +538,40 @@ public void
cadonna commented on code in PR #15669:
URL: https://github.com/apache/kafka/pull/15669#discussion_r1557815764
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -498,6 +538,40 @@ public void
lianetm commented on PR #15669:
URL: https://github.com/apache/kafka/pull/15669#issuecomment-2043121631
Hey @cadonna, could you take a look if you have some time too? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lianetm commented on PR #15669:
URL: https://github.com/apache/kafka/pull/15669#issuecomment-2039970916
Hey @lucasbru, could you take a look at this when you have a chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lianetm opened a new pull request, #15669:
URL: https://github.com/apache/kafka/pull/15669
Minor changes for improving the logging and docs related to the auto-commit
inflight logic, also adding tests to ensure the expected behaviour:
- auto-commit on the interval does not send a
