showuon merged PR #15748:
URL: https://github.com/apache/kafka/pull/15748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15748:
URL: https://github.com/apache/kafka/pull/15748#issuecomment-2073928078
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kamalcph commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1576190364
##
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
kamalcph commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1576175394
##
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
kamalcph commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1576175394
##
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
showuon commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1575561675
##
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
kamalcph commented on PR #15748:
URL: https://github.com/apache/kafka/pull/15748#issuecomment-2071274526
@showuon
Test failures are fixed! Please take another look. Let me know if we have to
fix the tests in 3.7 and trunk (but they weren't flaky).
--
This is an automated message
showuon commented on PR #15748:
URL: https://github.com/apache/kafka/pull/15748#issuecomment-2063302914
@kamalcph , the tests are still failing:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15748/
--
This is an automated message from the Apache Git Service.
To respond to
showuon merged PR #15747:
URL: https://github.com/apache/kafka/pull/15747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15747:
URL: https://github.com/apache/kafka/pull/15747#issuecomment-2062884304
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
showuon commented on PR #15748:
URL: https://github.com/apache/kafka/pull/15748#issuecomment-2062882937
Looks like `LogCleanerParameterizedIntegrationTest` failed due to this
change. Please take a look. Thanks.
kamalcph commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2062050733
> @kamalcph : Do you want this PR to be in 3.7 and 3.6? If so, could you
create a separate cherry-pick RP? Thanks.
Opened #15747 and #15748 to backport it to 3.7 and 3.6 branches.
kamalcph opened a new pull request, #15748:
URL: https://github.com/apache/kafka/pull/15748
cherry-picked from: d092787487047178c674bd60a182129a8d997c4a
Co-authored-by: hzh0425 <642256...@qq.com>
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
kamalcph opened a new pull request, #15747:
URL: https://github.com/apache/kafka/pull/15747
cherry-picked from: d092787487047178c674bd60a182129a8d997c4a
Co-authored-by: hzh0425 <642256...@qq.com>
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
junrao commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2061739168
@kamalcph : Do you want this PR to be in 3.7 and 3.6? If so, could you
create a separate cherry-pick RP? Thanks.
--
This is an automated message from the Apache Git Service.
To respond
junrao merged PR #15631:
URL: https://github.com/apache/kafka/pull/15631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2061732009
@kamalcph : Thanks for triaging the failed tests. The PR LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kamalcph commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2060333550
@junrao
Gentle reminder. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kamalcph commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2053698624
Re-triggered the tests. Tests failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
junrao commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2052208460
@kamalcph : Thanks for the update. JDK 11 and Scala 2.13 didn't complete in
the last test run. Could you trigger another run of the tests?
--
This is an automated message from the
kamalcph commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2050932821
@junrao
Please take another look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kamalcph commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2046510235
Rebased the PR with trunk, the test failures are unrelated. Ran the 11
failed tests locally, all of them got succeeded:
```
./gradlew cleanTest core:test --tests
junrao commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2045573518
@kamalcph : Thanks for the updated PR. The code looks good to me. Do you
know why there were 106 failed tests?
--
This is an automated message from the Apache Git Service.
To respond to
kamalcph commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2044326621
@junrao
Addressed the review comments. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
junrao commented on code in PR #15631:
URL: https://github.com/apache/kafka/pull/15631#discussion_r1556331481
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -952,8 +952,9 @@ class UnifiedLogTest {
assertEquals(0, lastSeq)
}
- @Test
- def
kamalcph commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2028316319
Unit tests are not added to assert that the as the local-log-start-offset is
incremented before the segments are removed from inmemory table as it is in
private method. PTAL.
cc
26 matches
Mail list logo
