divijvaidya commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1985996064
For completenss, the associated commit was merged to 3.6, 3.7 and trunk
3.6
-https://github.com/apache/kafka/commit/b743f6fd884132c7a5c4e9d96ed62e3aec29007f
3.7 -
divijvaidya commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1985979960
@cmccabe the test `testStartupWithNonDefaultKControllerDynamicConfiguration`
has been failing since it has been introduced to 3.6 branch. See:
cmccabe commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1894711882
committed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
cmccabe closed pull request #15192: KAFKA-16126: Kcontroller dynamic
configurations may fail to apply at startup
URL: https://github.com/apache/kafka/pull/15192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cmccabe commented on PR #15192:
URL: https://github.com/apache/kafka/pull/15192#issuecomment-1891091446
I included a test. It sometimes passes even when the fix is not present,
because of the nature of the bug. Adding a `Thread.sleep` makes it consistently
fail in the buggy version.
--
cmccabe opened a new pull request, #15192:
URL: https://github.com/apache/kafka/pull/15192
Some kcontroller dynamic configurations may fail to apply at startup. This
happens because there is a race between registering the reconfigurables to the
DynamicBrokerConfig class, and receiving the
