junrao commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1553959430
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1553357069
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {
junrao commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1552178574
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {
showuon merged PR #15213:
URL: https://github.com/apache/kafka/pull/15213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15213:
URL: https://github.com/apache/kafka/pull/15213#issuecomment-1970152996
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
clolov commented on PR #15213:
URL: https://github.com/apache/kafka/pull/15213#issuecomment-1969562705
Heya @showuon, I tried to reproduce the compilation failure of the unrelated
test class locally, but have been unable to. I have rebased and kicked off a
new build in case this was a
clolov commented on PR #15213:
URL: https://github.com/apache/kafka/pull/15213#issuecomment-1968689211
Apologies, I have had a lot of work recently, I will aim to provide an
update by the end of the day today
--
This is an automated message from the Apache Git Service.
To respond to the
showuon commented on PR #15213:
URL: https://github.com/apache/kafka/pull/15213#issuecomment-1965678417
@clolov , do we have any update about the compilation error fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
showuon commented on PR #15213:
URL: https://github.com/apache/kafka/pull/15213#issuecomment-1951764274
@clolov , there's a compilation error in jdk 8/scala 2.12. Could you help
fix it? Maybe rebasing to the latest trunk could solve it?
--
This is an automated message from the Apache Git
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1482965204
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1301,29 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
satishd commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1481778242
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1301,29 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
clolov commented on PR #15213:
URL: https://github.com/apache/kafka/pull/15213#issuecomment-1932149971
Heya @showuon @kamalcph @satishd, I hope I have addressed the latest
comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1481540437
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1301,29 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1481322702
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1279,7 +1281,6 @@ class UnifiedLog(@volatile var logStartOffset: Long,
if
satishd commented on PR #15213:
URL: https://github.com/apache/kafka/pull/15213#issuecomment-1922694144
I will take a look at this PR by Monday(5th).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1474112419
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1279,7 +1281,6 @@ class UnifiedLog(@volatile var logStartOffset: Long,
if
clolov commented on PR #15213:
URL: https://github.com/apache/kafka/pull/15213#issuecomment-1905886714
Thanks a lot for the review @kamalcph! I have hopefully addressed everything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1463164583
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
kamalcph commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1458606590
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp
kamalcph commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1458560112
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1455525955
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
clolov opened a new pull request, #15213:
URL: https://github.com/apache/kafka/pull/15213
### Summary
This is the first part of the implementation of
[KIP-1005](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1005%3A+Expose+EarliestLocalOffset+and+TieredOffset)
The
22 matches
Mail list logo
