Re: [PR] KAFKA-16164: Pre-Vote, modifying vote RPCs [part 1] [kafka]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #15231: URL: https://github.com/apache/kafka/pull/15231#issuecomment-2071344453 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-16164: Pre-Vote, modifying vote RPCs [part 1] [kafka]

2024-01-23 Thread via GitHub
jsancio commented on code in PR #15231: URL: https://github.com/apache/kafka/pull/15231#discussion_r1463743747 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -562,33 +568,37 @@ private VoteResponseData handleVoteRequest(

Re: [PR] KAFKA-16164: Pre-Vote, modifying vote RPCs [part 1] [kafka]

2024-01-23 Thread via GitHub
hachikuji commented on code in PR #15231: URL: https://github.com/apache/kafka/pull/15231#discussion_r1463806130 ## clients/src/main/resources/common/message/VoteRequest.json: ## @@ -18,7 +18,8 @@ "type": "request", "listeners": ["controller"], "name": "VoteRequest", -

Re: [PR] KAFKA-16164: Pre-Vote, modifying vote RPCs [part 1] [kafka]

2024-01-23 Thread via GitHub
jsancio commented on code in PR #15231: URL: https://github.com/apache/kafka/pull/15231#discussion_r1463743747 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -562,33 +568,37 @@ private VoteResponseData handleVoteRequest(

Re: [PR] KAFKA-16164: Pre-Vote, modifying vote RPCs [part 1] [kafka]

2024-01-23 Thread via GitHub
jsancio commented on code in PR #15231: URL: https://github.com/apache/kafka/pull/15231#discussion_r1463746152 ## clients/src/main/resources/common/message/VoteRequest.json: ## @@ -18,7 +18,8 @@ "type": "request", "listeners": ["controller"], "name": "VoteRequest", -

Re: [PR] KAFKA-16164: Pre-Vote, modifying vote RPCs [part 1] [kafka]

2024-01-23 Thread via GitHub
jsancio commented on code in PR #15231: URL: https://github.com/apache/kafka/pull/15231#discussion_r1463743747 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -562,33 +568,37 @@ private VoteResponseData handleVoteRequest(

Re: [PR] KAFKA-16164: Pre-Vote, modifying vote RPCs [part 1] [kafka]

2024-01-23 Thread via GitHub
hachikuji commented on code in PR #15231: URL: https://github.com/apache/kafka/pull/15231#discussion_r1463682475 ## clients/src/main/resources/common/message/VoteRequest.json: ## @@ -18,7 +18,8 @@ "type": "request", "listeners": ["controller"], "name": "VoteRequest", -