jolshan merged PR #15541:
URL: https://github.com/apache/kafka/pull/15541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2027801197
Some failing tests are due to
https://issues.apache.org/jira/browse/KAFKA-16447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jolshan commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2027424479
I don't have further comments. I will restart the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
CalvinConfluent commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2023173614
@kirktrue @jolshan Anything else we need to address for this ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kirktrue commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2013238826
@CalvinConfluent
I wonder if there's any value in the unit test for verifying that
`TransactionManager.close()` was invoked.
--
This is an automated message from the Apache
kirktrue commented on code in PR #15541:
URL: https://github.com/apache/kafka/pull/15541#discussion_r1529215985
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -270,14 +270,7 @@ public void run() {
while (!forceClose &&
jolshan commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-200839
Looks pretty reasonable to me. I also want to get a +1 from Kirk to make
sure he agrees it makes sense.
I will also let the tests run.
--
This is an automated message from the
CalvinConfluent commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2008340124
@kirktrue Move the test to the Sender test because less mock is needed to
repro the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message,
CalvinConfluent commented on code in PR #15541:
URL: https://github.com/apache/kafka/pull/15541#discussion_r1531252560
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -270,14 +270,7 @@ public void run() {
while (!forceClose &&
kirktrue commented on PR #15541:
URL: https://github.com/apache/kafka/pull/15541#issuecomment-2004890051
@CalvinConfluent—thanks for the PR!
This PR doesn't have any unit tests to verify the new behavior. Would it be
possible to migrate the test case from your _other PR_ (#15336) to
jolshan commented on code in PR #15541:
URL: https://github.com/apache/kafka/pull/15541#discussion_r1525612166
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -270,14 +270,7 @@ public void run() {
while (!forceClose &&
CalvinConfluent opened a new pull request, #15541:
URL: https://github.com/apache/kafka/pull/15541
This is a mitigation fix for the
https://issues.apache.org/jira/browse/KAFKA-16217. Exceptions should not block
closing the producers.
This PR reverts a part of the change
12 matches
Mail list logo
