Re: [PR] KAFKA-16225 Flaky test suite LogDirFailureTest#testIOExceptionDuringLogRoll [kafka]

2024-04-04 Thread via GitHub
chia7712 closed pull request #15637: KAFKA-16225 Flaky test suite LogDirFailureTest#testIOExceptionDuringLogRoll URL: https://github.com/apache/kafka/pull/15637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16225 Flaky test suite LogDirFailureTest#testIOExceptionDuringLogRoll [kafka]

2024-04-04 Thread via GitHub
chia7712 commented on PR #15637: URL: https://github.com/apache/kafka/pull/15637#issuecomment-2038837427 close as duplicate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-16225 Flaky test suite LogDirFailureTest#testIOExceptionDuringLogRoll [kafka]

2024-04-04 Thread via GitHub
gaurav-narula commented on PR #15637: URL: https://github.com/apache/kafka/pull/15637#issuecomment-2038293124 I think this might be due to KAFKA-16234 which has a PR at https://github.com/apache/kafka/pull/15335 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-16225 Flaky test suite LogDirFailureTest#testIOExceptionDuringLogRoll [kafka]

2024-04-01 Thread via GitHub
chia7712 commented on PR #15637: URL: https://github.com/apache/kafka/pull/15637#issuecomment-2030152641 That is interesting. it still fails on jenkins. will dig in it later and change this PR to draft -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-16225 Flaky test suite LogDirFailureTest#testIOExceptionDuringLogRoll [kafka]

2024-04-01 Thread via GitHub
chia7712 commented on code in PR #15637: URL: https://github.com/apache/kafka/pull/15637#discussion_r1545997106 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -877,9 +877,8 @@ class Partition(val topicPartition: TopicPartition, if

[PR] KAFKA-16225 Flaky test suite LogDirFailureTest#testIOExceptionDuringLogRoll [kafka]

2024-04-01 Thread via GitHub
chia7712 opened a new pull request, #15637: URL: https://github.com/apache/kafka/pull/15637 It seems to me the root cause is `LogDirFailureHandler#testIOExceptionDuringLogRoll` does not clean `directoryIds` in holding `replicaStateChangeLock`, and hence metadata event thread can see the