Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac merged PR #15364: URL: https://github.com/apache/kafka/pull/15364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1523572950 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1523564661 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1522871728 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberState.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1522869232 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1522334545 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1522334545 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1522316891 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberState.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on PR #15364: URL: https://github.com/apache/kafka/pull/15364#issuecomment-1991716363 @jolshan Thanks for your comments. I addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on PR #15364: URL: https://github.com/apache/kafka/pull/15364#issuecomment-1991715637 > > This is a non-backward compatible change. I think that we should do this change to cleanup the record. As KIP-848 is only in early access in 3.7 and that we clearly state that we don't

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521508636 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -931,17 +920,14 @@ public void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521507018 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -338,7 +338,6 @@ public void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521495237 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberState.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521494464 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -170,72 +127,122 @@ public CurrentAssignmentBuilder

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521491629 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -33,49 +33,6 @@ * The CurrentAssignmentBuilder

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521490928 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -528,27 +478,6 @@ public Map>

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521488580 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1796,12 +1834,12 @@ public void onLoaded() {

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521487635 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521482723 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1521477968 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520774849 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -931,17 +920,14 @@ public void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520772129 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -338,7 +338,6 @@ public void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520772129 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -338,7 +338,6 @@ public void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520418403 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberState.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520383812 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -33,49 +33,6 @@ * The CurrentAssignmentBuilder

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520414314 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -170,72 +127,122 @@ public CurrentAssignmentBuilder

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520383812 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -33,49 +33,6 @@ * The CurrentAssignmentBuilder

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520381484 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -528,27 +478,6 @@ public Map>

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520191884 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -37,4 +42,28 @@ public static OptionalInt ofSentinel(int value) { public

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520171958 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1796,12 +1834,12 @@ public void onLoaded() {

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520125834 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520113443 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jolshan commented on PR #15364: URL: https://github.com/apache/kafka/pull/15364#issuecomment-1988980430 > This is a non-backward compatible change. I think that we should do this change to cleanup the record. As KIP-848 is only in early access in 3.7 and that we clearly state that we

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jeffkbkim commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1508185648 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jeffkbkim commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1508179840 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1193,71 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jeffkbkim commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1508174554 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on PR #15364: URL: https://github.com/apache/kafka/pull/15364#issuecomment-1964189888 @jeffkbkim Thanks for your comments. I have addressed all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1502633032 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -2079,253 +2056,20 @@ public void testReconciliationProcess()

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jeffkbkim commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1496700583 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on PR #15364: URL: https://github.com/apache/kafka/pull/15364#issuecomment-1948535272 @jeffkbkim Thanks for your comments. I have addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492587334 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -251,195 +255,51 @@ private ConsumerGroupMember

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492585893 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -251,195 +255,51 @@ private ConsumerGroupMember

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492583068 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -170,72 +127,119 @@ public CurrentAssignmentBuilder

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492574501 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -779,7 +779,7 @@ private void maybeUpdateGroupState() {

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492567552 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -346,10 +346,9 @@ public static Record newCurrentAssignmentRecord(

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492563558 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492559984 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492557819 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492554402 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

jeffkbkim commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1491825284 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -346,10 +346,9 @@ public static Record newCurrentAssignmentRecord(

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1491144005 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -2079,253 +2056,20 @@ public void testReconciliationProcess()

[PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac opened a new pull request, #15364: URL: https://github.com/apache/kafka/pull/15364 TODO ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including