lucasbru merged PR #15594:
URL: https://github.com/apache/kafka/pull/15594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vamossagar12 commented on code in PR #15594:
URL: https://github.com/apache/kafka/pull/15594#discussion_r1570933991
##
tests/kafkatest/services/connect.py:
##
@@ -534,33 +535,40 @@ def received_messages(self):
def start(self):
self.logger.info("Creating
vamossagar12 commented on PR #15594:
URL: https://github.com/apache/kafka/pull/15594#issuecomment-2064120764
hey @lucasbru , I ran the following test suite
```
my_test_suite:
-
vamossagar12 commented on PR #15594:
URL: https://github.com/apache/kafka/pull/15594#issuecomment-2047030266
@lucasbru , that test did pass. However, let me try again with the snippet
you shared above and see if it works. Let me get back to you.
--
This is an automated message from the
lucasbru commented on PR #15594:
URL: https://github.com/apache/kafka/pull/15594#issuecomment-2046963651
@vamossagar12 did the test you ran pass?
Here is an example how I run parameterized tests using a test suite file:
```
consumer_test:
-
vamossagar12 commented on PR #15594:
URL: https://github.com/apache/kafka/pull/15594#issuecomment-2028815010
Thanks @kirktrue . I ran a single test by passing a parameter
```
kirktrue commented on PR #15594:
URL: https://github.com/apache/kafka/pull/15594#issuecomment-2025765078
@lucasbru—can you take a look at this system test change? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
philipnee commented on code in PR #15594:
URL: https://github.com/apache/kafka/pull/15594#discussion_r1541985614
##
tests/kafkatest/services/connect.py:
##
@@ -534,33 +535,40 @@ def received_messages(self):
def start(self):
self.logger.info("Creating connector
vamossagar12 commented on code in PR #15594:
URL: https://github.com/apache/kafka/pull/15594#discussion_r1539389617
##
tests/kafkatest/services/connect.py:
##
@@ -534,33 +535,40 @@ def received_messages(self):
def start(self):
self.logger.info("Creating
philipnee commented on code in PR #15594:
URL: https://github.com/apache/kafka/pull/15594#discussion_r1538356233
##
tests/kafkatest/services/connect.py:
##
@@ -534,33 +535,40 @@ def received_messages(self):
def start(self):
self.logger.info("Creating connector
vamossagar12 opened a new pull request, #15594:
URL: https://github.com/apache/kafka/pull/15594
Main changes:
1. Parameterizes the tests to use new coordinator and pass in consumer group
protocol. This would be applicable to sink connectors only.
2. Enhances the sink connector
11 matches
Mail list logo
