Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]

2024-04-18 Thread via GitHub
mjsax merged PR #15681: URL: https://github.com/apache/kafka/pull/15681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]

2024-04-11 Thread via GitHub
apoorvmittal10 commented on PR #15681: URL: https://github.com/apache/kafka/pull/15681#issuecomment-2050055971 > LGTM -- retriggered Jenkins (failure seems unrelated, but want to sanify check) -- Can merge afterwards. Thanks @mjsax. I can see unrelated tests failures as well and

Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]

2024-04-08 Thread via GitHub
apoorvmittal10 commented on PR #15681: URL: https://github.com/apache/kafka/pull/15681#issuecomment-2042866833 > Tiny nit. It's KIP-1019 I think, not KIP-109. Corrected the description. Thanks @AndrewJSchofield. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]

2024-04-08 Thread via GitHub
AndrewJSchofield commented on PR #15681: URL: https://github.com/apache/kafka/pull/15681#issuecomment-2042864722 Tiny nit. It's KIP-1019 I think, not KIP-109. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]

2024-04-08 Thread via GitHub
apoorvmittal10 opened a new pull request, #15681: URL: https://github.com/apache/kafka/pull/15681 The PR implements the changes defined in [KIP-109](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1019%3A+Expose+method+to+determine+Metric+Measurability) which exposes method to check